Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

StructuredDataEditorService remove fallback to first object

Description

Method DefaultStructuredDataEditorService#getCellXObject always defaults to the first object if the given objNb doesn't exist. This prevents the creation of new objects with objNb = -1 via the ajax request saveWithValidation.

Optional<BaseObject> getCellXObject(XWikiDocument cellDoc, XWikiDocument onDoc) { Optional<BaseObject> ret = ...; return ret.or(Optional.fromNullable(modelAccess.getXObject(onDoc, classRef.get()))); }

Change the behaviour so that it only falls back to the first object if no objNb is provided. Also rename to 'geXObjectInStructEditor'.

is blocked by

Activity

Show:

Marc Sladek 23 November 2017 at 13:07
Edited

I ran into difficulties understanding the defined requirements in the current usage of the StructEditor. Objects should be created with "-1" via the ajax request saveWithValidation, not inside getXObjectInStructEditor. Hence I went back to engineering the requirement and came up with another one. If I have misunderstood the problem at hand, please decline the PR with an appropriate explanation.

Done

Details

Priority

Assignee

Reporter

Sprint

Story Points

Components

Fix versions

Clockify

Created 31 October 2017 at 17:08
Updated 21 December 2017 at 14:47
Resolved 21 December 2017 at 14:47